[Maps] EMS baselayer should load cleanly #88531
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomasneirynck
added
[Deprecated-Use Team:Presentation]Team:Geo
|
Pinging @elastic/kibana-gis (Team:Geo) |
nreese
reviewed
Jan 15, 2021
x-pack/plugins/maps/public/classes/layers/vector_tile_layer/vector_tile_layer.js
Outdated
Show resolved
Hide resolved
x-pack/plugins/maps/public/classes/layers/vector_tile_layer/vector_tile_layer.js
Outdated
Show resolved
Hide resolved
nreese
reviewed
Jan 19, 2021
x-pack/plugins/maps/public/classes/layers/vector_tile_layer/vector_tile_layer.js
Show resolved
Hide resolved
nreese
approved these changes
Jan 19, 2021
💚 Build SucceededMetrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
thomasneirynck
added a commit
to thomasneirynck/kibana
that referenced
this pull request
Jan 19, 2021
thomasneirynck
added a commit
to thomasneirynck/kibana
that referenced
this pull request
Jan 19, 2021
thomasneirynck
added a commit
that referenced
this pull request
Jan 20, 2021
Co-authored-by: Kibana Machine <[email protected]>
thomasneirynck
added a commit
that referenced
this pull request
Jan 20, 2021
Co-authored-by: Kibana Machine <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes #88515
This bug was "revealed" by #87310.
vector_tile_layerwas loading the EMS-meta twice in short succession due to not correctly setting the metadata of the request. This did not cause end-user errors, just a double refresh cycle internally.By introducing #87310, the second refresh would throw an error, causing the layer-error to show up in the TOC.
The fix is that
vector_tile_layershould correctly set the metadata about the request. This way, thecanSkiplogic behaves as expected and there is no 2nd redundant refresh.Checklist
Delete any items that are not applicable to this PR.
For maintainers